Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLOC-3739] Failover acceptance test enabled #2546

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

itamarst
Copy link
Contributor

Builds on #2546.

  1. Enable the test on EBS, for now.
  2. Fix bug in EBS code that was caught by this. (The API for starting nodes is only used by this test, so it's a bit of a hack...).
  3. Fix some bugs in the test itself.
  4. News entry since acceptance test means the implementation is hopefully going to continue to work, so we can tell people about it.

@james-w
Copy link
Contributor

james-w commented Jan 29, 2016

The two tests keep failing, and then get timed out by Jenkins before they can
print the errors. I've increased the timeout on those two jobs on Jenkins to see
what the failures are.

Note that with these changes if it now takes more than 45 minutes for
run_acceptance_loopback_on_AWS_CentOS_7_for_flocker.acceptance
and run_acceptance_loopback_on_AWS_Ubuntu_Trusty_for_flocker.acceptance
to pass then build.yaml will have to be updated for them.

Pushing to this branch will overwrite my cowboy, so you might want to
change the timeouts in build.yaml if you have to do more work on this
branch, even if they are reverted before merging to master because
a passing run takes less than 45 minutes.

d = self.async_cloud_api.list_live_nodes()
d.addCallback(
lambda live:
self.assertTrue(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does assertIn work here?

@james-w
Copy link
Contributor

james-w commented Jan 29, 2016

✔️ I'm happy with this, thanks for the improvements.

Merge when you are happy and there are green tests, but I suspect there
may be work to do to get passing tests. A re-review of any changes needed
for that is at your discretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants